New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: Use version pinned by brew while executing rubocop cli #3179

Merged

MikeMcQuaid merged 1 commit into Homebrew:master from GauthamGoli:rubocop_cli_version

Sep 20, 2017

Contributor

GauthamGoli commented Sep 20, 2017 •

edited

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew tests with your changes locally?

If the user has a newer rubocop version than that of HOMEBREW_RUBOCOP_VERSION , then it leads to unexpected Homebrew/homebrew-core#18324 (comment)

This change ensures that rubocop version intended by brew is executed using an undocumented feature as described here https://stackoverflow.com/questions/4061596/how-can-i-call-an-older-version-of-a-gem-from-the-commandline


          audit: Use version pinned by brew while executing rubocop cli

17e2753

MikeMcQuaid approved these changes

View reviewed changes

Member

MikeMcQuaid commented Sep 20, 2017

Great work here, thanks @GauthamGoli!

MikeMcQuaid merged commit f343aab into Homebrew:master

Homebrew locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.